Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to README, default branch and repo link #5709

Merged
merged 2 commits into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: OmniSharp-VSCode CI

on:
push:
branches: [ master, feature/** ]
branches: [ main, feature/** ]

pull_request:
branches: [ master, feature/** ]
branches: [ main, feature/** ]

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ The 1.8 release makes a major change to how the debugger works under the hood. T
Changes:

* The module load messages in the output window are now more detailed and hopefully less confusing. ([#837](https://github.com/OmniSharp/omnisharp-vscode/issues/837))
* Programs can now be launched into VS Code's integrated terminal. ([documentation](https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger.md#console-terminal-window))
* Programs can now be launched into VS Code's integrated terminal. ([documentation](https://github.com/dotnet/vscode-csharp/blob/main/debugger.md#console-terminal-window))
* VS Code recently introduced [column breakpoint support](https://code.visualstudio.com/updates/v1_10#_column-breakpoints) and they are now enabled for C#.
* React to the VS Code change to use `${command:` instead of `${command.`. ([#1275](https://github.com/OmniSharp/omnisharp-vscode/issues/1275))
* Fix a problem with browser launch support that could lead to debugger session's being aborted when the browser is started. ([#1274](https://github.com/OmniSharp/omnisharp-vscode/issues/1274))
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## C# for Visual Studio Code

C# is the feature-rich, language support for C# in VS Code. This extension is being updated to be powered by a new fully open-source Language Server Protocol (LSP) Host. To use the LSP-powered version, click on the “Switch to Pre-Release Version” or “Install Pre-Release” button or above. To use the OmniSharp-powered version, click “Install Release Version” or continuing using the 1.x version you already have installed.
C# is the feature-rich, language support for C# in VS Code. This extension is being updated to be powered by a new fully open-source Language Server Protocol (LSP) Host. To use the LSP-powered version, click on the “Switch to Pre-Release Version” or “Install Pre-Release” button above. To use the OmniSharp-powered version, click “Install Release Version” or continuing using the 1.x version you already have installed.

Welcome to the C# extension for Visual Studio Code! This extension provides the following features inside VS Code:

Expand Down Expand Up @@ -34,7 +34,7 @@ If you still need Unity or .NET Framework support, you can set `omnisharp.useMod
See issue [#5120](https://github.com/OmniSharp/omnisharp-vscode/issues/5120) for more details.

## What's new in 1.25.9
* Readme updates (PR: [#5705](https://github.com/OmniSharp/omnisharp-vscode/pull/5672))
* Readme updates (PR: [#5705](https://github.com/OmniSharp/omnisharp-vscode/pull/5705))

## What's new in 1.25.8
* Update Razor to 7.0.0-preview.23258.1 (PR: [#5672](https://github.com/OmniSharp/omnisharp-vscode/pull/5672))
Expand Down
4 changes: 2 additions & 2 deletions debugger.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ Your project is now all set. Set a breakpoint or two where you want to stop, cli
### Debugging Code compiled on another computer
If your code was built on a different computer from where you would like to run in there are a few things to keep in mind --

* **Source Maps**: Unless your local source code is at exactly the same path as where the code was originally built you will need to add a [sourceFileMap](https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#source-file-map) to launch.json.
* **Source Maps**: Unless your local source code is at exactly the same path as where the code was originally built you will need to add a [sourceFileMap](https://github.com/dotnet/vscode-csharp/blob/main/debugger-launchjson.md#source-file-map) to launch.json.
* **Portable PDBs**: If the code was built on Windows, it might have been built using Windows PDBs instead of portable PDBs, but the C# extension only supports portable PDBs. See the [portable PDB documentation](https://github.com/OmniSharp/omnisharp-vscode/wiki/Portable-PDBs#how-to-generate-portable-pdbs) for more information.
* **Debug vs. Release**: It is much easier to debug code which has been compiled in the `Debug` configuration. So unless the issue you are looking at only reproduces with optimizations, it is much better to use Debug bits. If you do need to debug optimized code, you will need to disable [justMyCode](https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#just-my-code) in launch.json.
* **Debug vs. Release**: It is much easier to debug code which has been compiled in the `Debug` configuration. So unless the issue you are looking at only reproduces with optimizations, it is much better to use Debug bits. If you do need to debug optimized code, you will need to disable [justMyCode](https://github.com/dotnet/vscode-csharp/blob/main/debugger-launchjson.md#just-my-code) in launch.json.

#### [Configurating launch.json for C# Debugging](debugger-launchjson.md)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3645,7 +3645,7 @@
"description": "Environment variables passed to dotnet. Only valid for hosted apps."
},
"dotNetConfig": {
"description": "Options passed to the underlying .NET debugger. For more info, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger.md.",
"description": "Options passed to the underlying .NET debugger. For more info, see https://github.com/dotnet/vscode-csharp/blob/main/debugger.md.",
"type": "object",
"required": [],
"default": {},
Expand Down
4 changes: 2 additions & 2 deletions src/assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export function createWebLaunchConfiguration(programPath: string, workingDirecto
const configuration = {
"OS-COMMENT1": "Use IntelliSense to find out which attributes exist for C# debugging",
"OS-COMMENT2": "Use hover for the description of the existing attributes",
"OS-COMMENT3": "For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md",
"OS-COMMENT3": "For further information visit https://github.com/dotnet/vscode-csharp/blob/main/debugger-launchjson.md",
"name": ".NET Core Launch (web)",
"type": "coreclr",
"request": "launch",
Expand Down Expand Up @@ -345,7 +345,7 @@ export function createLaunchConfiguration(programPath: string, workingDirectory:
const configuration = {
"OS-COMMENT1": "Use IntelliSense to find out which attributes exist for C# debugging",
"OS-COMMENT2": "Use hover for the description of the existing attributes",
"OS-COMMENT3": "For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md",
"OS-COMMENT3": "For further information visit https://github.com/dotnet/vscode-csharp/blob/main/debugger-launchjson.md",
"name": ".NET Core Launch (console)",
"type": "coreclr",
"request": "launch",
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr-debug/debugConfigurationProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function checkForDevCerts(dotNetCliPaths: string[], eventStream: EventStream){
}
if (result?.title === labelMoreInfo)
{
const launchjsonDescriptionURL = 'https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#check-for-devcert';
const launchjsonDescriptionURL = 'https://github.com/dotnet/vscode-csharp/blob/main/debugger-launchjson.md#check-for-devcert';
vscode.env.openExternal(vscode.Uri.parse(launchjsonDescriptionURL));
checkForDevCerts(dotNetCliPaths, eventStream);
}
Expand Down
2 changes: 1 addition & 1 deletion test-plan.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- Windows: .NET Framework along with [MSBuild Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2022)
- MacOS/Linux: [Mono with MSBuild](https://www.mono-project.com/download/stable/)

See [OmniSharp Options](https://github.com/OmniSharp/omnisharp-vscode/blob/master/test-plan.md#omnisharpusemodernnet-all-platforms) for more details.
See [OmniSharp Options](https://github.com/dotnet/vscode-csharp/blob/main/test-plan.md#omnisharpusemodernnet-all-platforms) for more details.

### Validation

Expand Down