-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization to debugger components #6064
Conversation
This PR adds in localization via vscode.l10n.t(...) calls to the strings used in the debugger components of vscode-csharp.
Whats the best way to localize this block? vscode-csharp/src/shared/assets.ts Lines 453 to 469 in 621a362
|
My thought:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
|
This PR adds in localization via vscode.l10n.t(...) calls to the strings
used in the debugger components of vscode-csharp.
This also moves the tests that now call vscode.l10n.t to be integration tests.
Also refactored DotnetInfo to its own file to avoid pulling in vscode for unit tests.