Fix Razor browser discovery issues on Mac and Linux #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonchou
commented
Sep 2, 2023
| showErrorMessage(vscode, vscode.l10n.t('Run and Debug: A valid browser is not installed')); | ||
| showErrorMessage( | ||
| vscode, | ||
| vscode.l10n.t('Run and Debug: A valid browser is not installed. Please install Edge or Chrome.') |
There was a problem hiding this comment.
Updated error message to explicitly say which browsers we support.
| const chromeBrowserFinder = new ChromeBrowserFinder(process.env, promises, null); | ||
| const chromeInstallations = await chromeBrowserFinder.findAll(); | ||
| if (chromeInstallations.length > 0) { | ||
| // favoring Edge if multiple valid options are installed. |
There was a problem hiding this comment.
Thought we should re-order browser priority so that we favor Edge over Chrome (since we're Microsoft 😄). Let me know if anyone has other thoughts.
allisonchou
changed the title
allisonchou
requested review from
ryzngard,
davidwengier,
maryamariyan and
phil-allen-msft
davidwengier
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1842267/ and
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1865790/
Marked as dupes but they were actually two separate issues:
@vscode/js-debug-browsers, which we use to determine which browsers the user has installed, expected anexecaobject to be passed into one of their methods we were calling. However, they only expected this on Macs (which is probably why this wasn't caught sooner).@vscode/js-debug-browsersto a newer version, since the old version contained buggy code that resulted in one of the filed bugs above.Other notes: