Pass ForceNoAlign to ensure msbuild output is parseable by the vscode problem matcher #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
forcenoalign
branch
from
7245ba6
to
7b53021
Compare
|
@dotnet-policy-service rerun |
|
Any idea why it says cpp? |
That is defined here - https://github.com/microsoft/vscode/blob/24739b3e01f8f7d27efa33e7ff9101fb8157032d/src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L1928 I believe because this is used for either cpp or C#. At some point we may need to change the problem matcher, but its not high priority for me at the moment |
|
@dotnet-policy-service rerun |
Cosifne
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the terminal size is adjusted, msbuild can alter the output making it unparseable by the vscode problem matcher. This flag makes msbuild not attempt to align the output based on the terminal size.
See https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-command-line-reference?view=vs-2022
This flag is also used by devkit for a similar reason, see https://devdiv.visualstudio.com/DevDiv/_git/vs-green?path=/tools/msbuild/Directory.Build.rsp&version=GBmain&line=16&lineEnd=17&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents (internal)
Resolves #6309
Fixed:
Before:
