Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass ForceNoAlign to ensure msbuild output is parseable by the vscode problem matcher #6340

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Pass ForceNoAlign to ensure msbuild output is parseable by the vscode problem matcher #6340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions omnisharptest/omnisharpFeatureTests/assets.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ suite('Asset generation: csproj', () => {
// We do not check the watch task since this parameter can break hot reload scenarios.
tasksJson.tasks
.filter((task) => task.label !== 'watch')
.forEach((task) => task.args!.should.contain('/consoleloggerparameters:NoSummary'));
.forEach((task) => task.args!.should.contain('/consoleloggerparameters:NoSummary;ForceNoAlign'));
});

test("Generated 'watch' task does not have the property GenerateFullPaths set to true ", () => {
Expand Down Expand Up @@ -111,7 +111,7 @@ suite('Asset generation: csproj', () => {

const watchTask = tasksJson.tasks!.find((task) => task.label === 'watch');
isNotNull(watchTask?.args);
watchTask.args.should.not.contain('/consoleloggerparameters:NoSummary');
watchTask.args.should.not.contain('/consoleloggerparameters:NoSummary;ForceNoAlign');
});

test('Create tasks.json for nested project opened in workspace', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export class AssetGenerator {
}

commandArgs.push('/property:GenerateFullPaths=true');
commandArgs.push('/consoleloggerparameters:NoSummary');
commandArgs.push('/consoleloggerparameters:NoSummary;ForceNoAlign');
}

private getBuildProjectPath(): string | null {
Expand Down