Fix isSubfolderOf to correctly determine if a folder is a subfolder #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Sep 15, 2023
| */ | ||
| export function isSubfolderOf(subfolder: string, folder: string): boolean { | ||
| export function isSubfolderOf(subfolder: string, parentFolder: string): boolean { |
There was a problem hiding this comment.
the previous version of this made no sense - it was checking that folder was a subfolder of subfolder. I renamed the parameters to be more clear and reversed the check.
There was only one usage of this function in the O# workspace configuration provider.
JoeRobich
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was testing project loading in O# and discovered this issue. Not sure how long it has been broken. Shoud only affect O#.