Add support for collecting dumps on crash #6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunchndr
approved these changes
Sep 26, 2023
jasonmalinowski
approved these changes
Sep 26, 2023
| env.DOTNET_DbgMiniDumpType = '2'; | ||
| // Collect crashreport.json with additional thread and stack frame information. | ||
| env.DOTNET_EnableCrashReport = '1'; | ||
| env.DOTNET_DbgMiniDumpName = path.join(languageServerOptions.crashDumpPath, '%e.%d.dmp'); |
There was a problem hiding this comment.
You might want to comment what the substitutions do here, especially because I don't see what %d does in the docs. Did you mean %p?
There was a problem hiding this comment.
Ah %d is the old one, see https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/xplat-minidump-generation.md#configurationpolicy
I'll add a comment and change to %p
dibarbet
force-pushed
the
crash_dumps
branch
from
b22440b
to
4517f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to easily capture a crash dump of the language server process.