Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required VSCode version to account for APIs in vscode-extension-telementry #6711

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Update required VSCode version to account for APIs in vscode-extension-telementry #6711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@
}
],
"engines": {
"vscode": "^1.73.0"
"vscode": "^1.75.0"
},
"activationEvents": [
"onDebugInitialConfigurations",
Expand All @@ -1023,18 +1023,7 @@
"onDebugResolve:clr",
"onDebugResolve:dotnet",
"onLanguage:csharp",
"onLanguage:aspnetcorerazor",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the version added a warning here that these were not necessary (they are automatically generated now based on the commands we list).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the "onLanguage:aspnetcorerazor" one? was it similarly not necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!
image

"onCommand:o.restart",
"onCommand:o.pickProjectAndStart",
"onCommand:o.showOutput",
"onCommand:dotnet.restore.project",
"onCommand:dotnet.restore.all",
"onCommand:dotnet.generateAssets",
"onCommand:dotnet.openSolution",
"onCommand:csharp.downloadDebugger",
"onCommand:csharp.listProcess",
"onCommand:csharp.listRemoteProcess",
"onCommand:csharp.listRemoteDockerProcess",
"onCommand:omnisharp.registerLanguageMiddleware",
"workspaceContains:project.json",
"workspaceContains:**/*.{csproj,sln,slnf,csx,cake}"
Expand Down