Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description of debugger console setting #6726

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix description of debugger console setting #6726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f11b8c2
Fix description of debugger `console` setting
gregg-miskelly Dec 7, 2023
51d8067
Increase VSIX Max Size
gregg-miskelly Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,16 @@
"Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered."
]
},
"generateOptionsSchema.console.markdownDescription": "When launching console projects, indicates which console the target program should be launched into.",
"generateOptionsSchema.console.markdownDescription": "Indicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
"generateOptionsSchema.console.settingsDescription": {
"message": "**Note:** _This option is only used for the `dotnet` debug configuration type_.\n\nWhen launching console projects, indicates which console the target program should be launched into.",
"message": "**Note:** _This option is only used for console projects launched with the `dotnet` debug configuration type_.\n\nIndicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
"comment": [
"Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered."
]
},
"generateOptionsSchema.console.internalConsole.enumDescription": "Output to the VS Code Debug Console. This doesn't support reading console input (ex:Console.ReadLine).",
"generateOptionsSchema.console.integratedTerminal.enumDescription": "VS Code's integrated terminal.",
"generateOptionsSchema.console.externalTerminal.enumDescription": "External terminal that can be configured via user settings.",
"generateOptionsSchema.console.internalConsole.enumDescription": "The target process's console input (stdin) and output (stdout/stderr) are routed through the VS Code Debug Console.",
"generateOptionsSchema.console.integratedTerminal.enumDescription": "The target process will run inside VS Code's integrated terminal.",
"generateOptionsSchema.console.externalTerminal.enumDescription": "The target process will run inside its own external terminal. When using this mode, you will need to switch focus between Visual Studio Code and the external terminal window.",
"generateOptionsSchema.externalConsole.markdownDescription": {
"message": "Attribute `externalConsole` is deprecated, use `console` instead. This option defaults to `false`.",
"comment": [
Expand Down
10 changes: 5 additions & 5 deletions src/tools/OptionsSchema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,12 @@
"type": "string",
"enum": [ "internalConsole", "integratedTerminal", "externalTerminal" ],
"enumDescriptions": [
"Output to the VS Code Debug Console. This doesn't support reading console input (ex:Console.ReadLine).",
"VS Code's integrated terminal.",
"External terminal that can be configured via user settings."
"The target process's console input (stdin) and output (stdout/stderr) are routed through the VS Code Debug Console.",
"The target process will run inside VS Code's integrated terminal.",
"The target process will run inside its own external terminal. When using this mode, you will need to switch focus between Visual Studio Code and the external terminal window."
],
"markdownDescription": "When launching console projects, indicates which console the target program should be launched into.",
"settingsDescription": "**Note:** _This option is only used for the `dotnet` debug configuration type_.\n\nWhen launching console projects, indicates which console the target program should be launched into.",
"markdownDescription": "Indicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
"settingsDescription": "**Note:** _This option is only used for console projects launched with the `dotnet` debug configuration type_.\n\nIndicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
"default": "internalConsole"
},
"externalConsole": {
Expand Down
2 changes: 1 addition & 1 deletion test/artifactTests/vsix.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('Vscode VSIX', () => {
vsixFiles.forEach((element) => {
// We're packaging the platform specific Roslyn server with ready to run in the vsix, so the size should be roughly ~50MB
// We also publish the Razor server, which is roughly ~75MB
const sizeInMB = 220;
const sizeInMB = 230;
const maximumVsixSizeInBytes = sizeInMB * 1024 * 1024;

describe(`Given ${element}`, () => {
Expand Down
Loading