Allow rzls to launch using standard dotnet (Redo) #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maryamariyan
commented
Feb 1, 2024
maryamariyan
commented
- Updates where to pick up dotnet.exe.
- Contributes to making rzls move away from being self-contained.
- Unifies how roslyn and razor servers acquire dotnet path/env variables.
- Picks up leftover changes from Allow rzls to launch using standard dotnet #5855 into main
- Updates where to pick up dotnet.exe. - Contributes to making rzls move away from being self-contained. - Unifies how roslyn and razor servers acquire dotnet path/env variables. - Picks up leftover changes from #5855 into main
davidwengier
approved these changes
Feb 1, 2024
dibarbet
approved these changes
Feb 1, 2024
| vscode.l10n.t("Could not find Razor Language Server executable within directory '{0}'", withinDir) | ||
| ); | ||
| } | ||
| fullPath = path.join(withinDir, 'rzls.dll'); |
There was a problem hiding this comment.
Just a note here - it is possible to publish a non-self contained executable if you wanted to
https://learn.microsoft.com/en-us/dotnet/core/deploying/#publish-framework-dependent
The benefit of the executable is that your process name is the executable name. Whereas if you launch with dotnet rzls.dll your executable name will be 'dotnet'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.