Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for formatting code block open braces #6939

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

davidwengier
Copy link
Contributor

VS Code option for dotnet/razor#10018

"type": "boolean",
"scope": "window",
"default": false,
"description": "Forces the open brace after an @code or @functions directive to be on the following line."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect this to be localized?

Copy link
Member

@Cosifne Cosifne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the change to be Eng only right now. Seems other options are also not localized. So it might be good to do that in another PR.

@davidwengier
Copy link
Contributor Author

Fine with the change to be Eng only right now. Seems other options are also not localized. So it might be good to do that in another PR.

Thanks for the heads up, I just copied the existing pattern and didn't really think about it. Logged dotnet/razor#10025 to fix this in another PR.

davidwengier added a commit to dotnet/razor that referenced this pull request Mar 5, 2024
@davidwengier davidwengier merged commit 091ed53 into dotnet:main Mar 5, 2024
13 checks passed
@davidwengier davidwengier deleted the CodeBlockFormattingOption branch March 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants