Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump razor #7005

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Bump razor #7005

merged 3 commits into from
Mar 26, 2024

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard requested a review from a team as a code owner March 26, 2024 03:21
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the changelog as well with the fixes in this insertion?

@ryzngard
Copy link
Contributor Author

Would you mind updating the changelog as well with the fixes in this insertion?

I did it manually by diffing builds, but is there a tool we have for this?

@dibarbet
Copy link
Member

I did it manually by diffing builds, but is there a tool we have for this?

In the razor repo, you can run roslyn-tools pr-finder -p <previous commit> -c <current commit> --format o# once you have the roslyn-tools global tool installed.

Then I usually filter out everything that isn't relevant for vscode / adjust titles to better explain the changes.

@davidwengier
Copy link
Contributor

I knew about the pr-finder, and used to use it weekly for VS Mac insertions, and I have written every single changelog update manually. I cannot believe I didn't think of this. 🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️

CHANGELOG.md Outdated
* Fix hot path string allocations from ProjectKey (PR: [#10138](https://github.com/dotnet/razor/pull/10138))
* Disable latest runtime patch (PR: [#10133](https://github.com/dotnet/razor/pull/10133))


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: Two blank lines (though I doubt markdown cares) and BackgroundDocumentGenerator is not used in VS Code (though I doubt anyone reading the notes cares.. or indeed reads the notes 😛)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceballsFunnyGIF

@maryamariyan
Copy link
Member

Thanks for the comments and thank you @ryzngard for helping out

@ryzngard ryzngard merged commit c33812c into dotnet:main Mar 26, 2024
11 checks passed
@ryzngard ryzngard deleted the bump_razor branch March 26, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants