Download razor telemetry nupkg and include in vsix #7236
Conversation
I don't have a strong opinion here. the duplicate dll is just the telemetry dll, and technically we may be on a separate version than Roslyn. If we decide to require the same version then we could probably reduce size slightly |
|
I was thinking duplicated dlls between our two nupkgs, like shared code or workspaces.DLL maybe. If there isn't any, then great, ignore me :) |
| }; | ||
|
|
||
| export function getComponentPaths(componentName: string, options: LanguageServerOptions): string[] { | ||
| export function getComponentPaths(componentName: string, options: LanguageServerOptions | undefined): string[] { |
There was a problem hiding this comment.
instead of having this undefined you could consider adding the razorDevkit folder as a component path option. Then you would be able to override it for local development.
There was a problem hiding this comment.
I think the only issue I have with that is the structure LanguageServerOptions has a lot of concepts that don't apply to razor. Could we move the options to a lighter interface?
There was a problem hiding this comment.
I guess technically the other options aren't relevant to you, but you can just import languageServerOptions and pass it to the function (without caring what else is on it). Actually, frankly builtInComponents.ts should probably just call languageServerOptions.componentPaths and not even have options be a parameter.
There was a problem hiding this comment.
We could move it to CommonOptions as well, but not sure if its necessary to do that
There was a problem hiding this comment.
Actually, frankly builtInComponents.ts should probably just call languageServerOptions.componentPaths and not even have options be a parameter
I'll look into that. Seems cleaner
There was a problem hiding this comment.
Actually let me see about that in a follow up. Would like to get this in for now since I'll likely have another razor change coming in that will require dual insertion
Co-authored-by: David Wengier <[email protected]>
Updates to https://dev.azure.com/dnceng/internal/_build/results?buildId=2475112&view=results to have correct nuget packaging.