Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map dotnet.implementType options to their new names #7356

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Map dotnet.implementType options to their new names #7356

merged 5 commits into from
Jul 17, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 16, 2024 •
edited
Loading

Update Roslyn.

@tmat tmat mentioned this pull request Jul 16, 2024
Merged
dibarbet
dibarbet approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the changelog mentioning the rename (under the latest section)

Approved pending roslyn server version update

src/shared/migrateOptions.ts Outdated Show resolved Hide resolved
src/shared/migrateOptions.ts Outdated Show resolved Hide resolved
dibarbet
dibarbet reviewed Jul 16, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tmat tmat force-pushed the ImplementTypeOptionMapping branch from bf906b8 to 8c7bb57 Compare July 17, 2024 18:56
@tmat tmat marked this pull request as ready for review July 17, 2024 18:56
@tmat tmat requested a review from a team as a code owner July 17, 2024 18:56
@tmat tmat merged commit 60202f9 into dotnet:main Jul 17, 2024
13 checks passed
@tmat tmat deleted the ImplementTypeOptionMapping branch July 17, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @dibarbet