-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a TextDocumentContentProvider for source-generated files #7581
Merged
dibarbet
merged 3 commits into
dotnet:main
from
dibarbet:open_source_generated_documents
Oct 4, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.txt in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import * as vscode from 'vscode'; | ||
import * as RoslynProtocol from './roslynProtocol'; | ||
import { RoslynLanguageServer } from './roslynLanguageServer'; | ||
import { UriConverter } from './uriConverter'; | ||
import * as lsp from 'vscode-languageserver-protocol'; | ||
|
||
export function registerSourceGeneratedFilesContentProvider( | ||
context: vscode.ExtensionContext, | ||
languageServer: RoslynLanguageServer | ||
) { | ||
context.subscriptions.push( | ||
vscode.workspace.registerTextDocumentContentProvider( | ||
'roslyn-source-generated', | ||
new (class implements vscode.TextDocumentContentProvider { | ||
async provideTextDocumentContent(uri: vscode.Uri, token: vscode.CancellationToken): Promise<string> { | ||
const result = await languageServer.sendRequest( | ||
RoslynProtocol.SourceGeneratorGetTextRequest.type, | ||
{ textDocument: lsp.TextDocumentIdentifier.create(UriConverter.serialize(uri)) }, | ||
token | ||
); | ||
return result.text; | ||
} | ||
})() | ||
) | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we definitely need to add refresh support in. There is some interesting behavior where VSCode doesn't actually always call didClose on the document even if the only active view closes (it calls sometimes much later). So the content gets reused even if the view is closed and another go to def request is made.
I could implement a command to refresh, or refresh on textview changing, but IMHO we should just implement server side refresh instead.