Make sure named pipe awaits server start #7645
Conversation
In cases where the workspace does not contain a razor or cshtml file startup is delayed for razor. This helps make sure we don't initialize when not needed. That also means that if a user opens a solution that contains a reference to a project outside of the workspace then startup will be delayed. This is generally fine because it will be initialized when needed, but there was an issue where the named pipe setup was trying to wait the startup task that had not been created yet. An await on undefined immediately returns and the project system will never get information about the project through the named pipe.
| @@ -223,7 +223,7 @@ export class RazorLanguageServerClient implements vscode.Disposable { | |||
| } | |||
|
|
|||
| public async connectNamedPipe(pipeName: string): Promise<void> { | |||
| await this.startHandle; | |||
| await this.start(); | |||
There was a problem hiding this comment.
I'm not sure I understand this. You said that previous it could wait on startHandle before it had been created, due to delayed initialization, which makes sense, but this makes it look like this will actually start things up instead. Doesn't that break the delayed initialization?
This change makes sense if we know that connectNamedPipe is only called after something else has started the Razor bits, but if that were true then I don't see how the old code would have been problematic.
Or does start() have a wait inside it that waits for a file to appear in the workspace? That would make sense, but if so, perhaps a comment here mentioning that, and why its okay to call start here, would be good to add.
There was a problem hiding this comment.
From my understanding this happens anytime roslyn would ask for dynamic file information from razor:
At that point we should be starting up right? Otherwise dynamic file info will never be provided. If that's not the case then I could add this to check if razor is started, add a callback for after it started
There was a problem hiding this comment.
Okay, I see it now. There is a gap where a there could be no Razor files in the VS Code workspace, but they do exist in a Roslyn project. Odd, but fair enough. I had a quick look at it seems fine if this happens to be where the language server starts. Sorry, I didn't pay enough attention to where you mentioned this in the PR description.
In cases where the workspace does not contain a razor or cshtml file startup is delayed for razor. This helps make sure we don't initialize when not needed. That also means that if a user opens a solution that contains a reference to a project outside of the workspace then startup will be delayed. This is generally fine because it will be initialized when needed, but there was an issue where the named pipe setup was trying to wait the startup task that had not been created yet. An await on undefined immediately returns and the project system will never get information about the project through the named pipe.
[Cherry-Pick] Make sure named pipe awaits server start (#7645)
Fixes microsoft/vscode-dotnettools#1470
In cases where the workspace does not contain a razor or cshtml file startup is delayed for razor.
This helps make sure we don't initialize when not needed. That also means that if a user opens a solution that contains a reference
to a project outside of the workspace then startup will be delayed. This is generally fine because it will be
initialized when needed, but there was an issue where the named pipe setup was trying to wait the startup task
that had not been created yet. An await on undefined immediately returns and the project system will never get
information about the project through the named pipe.