Allow opting in to using the Roslyn tokenizer in Razor files #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Nov 11, 2024
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Nov 12, 2024
This makes the feature work in VS and VS Code (with corresponding VS Code change to pass the right flag, coming once this is merged) VS Code PR: dotnet/vscode-csharp#7748 /cc @danroth27, @leslierichardson95, @333fred, @chsienki and anyone else who wants, for wording: VS Code: https://github.com/dotnet/vscode-csharp/pull/7748/files#diff-9b29d8b47a74097a04da353b72a8632d485d658282457b97b4caf26575a42dd0R131 VS: https://github.com/dotnet/razor/pull/11185/files#diff-18b9b146f4d27a6a5b6248ece31b30570d84c2a409b25bf5b660de86e608fa4cR80
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dibarbet
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the feature work in VS and VS Code (with corresponding VS Code change to pass the right flag, coming once this is merged)
VS Code side of dotnet/razor#11185
Razor bump to come once that is merged, and I'll include dotnet/roslyn#75794 and corresponding version bump too, so serialization works.