Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable integration tests partially #6532

Closed
kant2002 opened this issue Jan 21, 2022 · 2 comments
Closed

Reenable integration tests partially #6532

kant2002 opened this issue Jan 21, 2022 · 2 comments
Labels
api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation no-recent-activity test-enhancement Improvements of test source code waiting-author-feedback The team requires more information from the author

Comments

@kant2002
Copy link
Contributor

As part of #6091 not only MAUI tests was disabled, but and some end-to-end tests for folder browser dialog box for example. Because I add that tests I did not expect that.

My question is following, can we re-enable non-MAUI test in System.Windows.Forms.IntegrationTests.csproj? If they should be rewriten, then how? In order for me to safely migrate code to ComWrappers I would like to have this kind of tests in place and running.

@kant2002 kant2002 added the api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation label Jan 21, 2022
@RussKie
Copy link
Member

RussKie commented Jan 24, 2022

The tests in src/System.Windows.Forms/tests/IntegrationTests/System.Windows.Forms.IntegrationTests/WinformsControlsTest.cs are generally quite meaningless, they generally don't assert anything beyond "looks like we were able to open a dialog with controls", the E2E tests need to be migrated into the UIIntegrationTests project, where we can assert specific aspects of functionality for each control.

We already have unit tests for the dialogs, and more were added in #6244. It'd be great if you could check for any gaps, and fill them, if necessary. Also please have a look at the tests in UIIntegrationTests project, it should be fairly straight forward to add dialog specific tests there.

@RussKie RussKie added api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation test-enhancement Improvements of test source code waiting-author-feedback The team requires more information from the author and removed api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation labels Jan 24, 2022
@RussKie RussKie added this to the .NET 7.0 milestone Feb 4, 2022
@ghost ghost added the no-recent-activity label Feb 18, 2022
@ghost
Copy link

ghost commented Feb 18, 2022

This submission has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 14 days.

It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this as completed Feb 25, 2022
@ghost ghost removed this from the .NET 7.0 milestone Feb 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-suggestion (1) Early API idea and discussion, it is NOT ready for implementation no-recent-activity test-enhancement Improvements of test source code waiting-author-feedback The team requires more information from the author
Projects
None yet
Development

No branches or pull requests

2 participants