Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older browsers in JS #85

Closed
zizther opened this issue May 23, 2023 · 3 comments
Closed

Support for older browsers in JS #85

zizther opened this issue May 23, 2023 · 3 comments
Labels
Bug Report Something isn't working

Comments

@zizther
Copy link

zizther commented May 23, 2023

There are still some users who have devices not on iOS v14+ which supports nullish coalescing operators which are being used in the plugin JS.
Would it be possible to support these?

For example dynamicmap.js Line 1310:
this._cluster.algorithm ?? null

@lindseydiloreto lindseydiloreto added the Bug Report Something isn't working label Jun 2, 2023
@lindseydiloreto
Copy link
Collaborator

Thanks for reporting! This is now fixed on the v4-dev branch.

To test it out before the next release, change the plugin version specified in composer.json...

"doublesecretagency/craft-googlemaps": "dev-v4-dev"

Then run composer update.

Let me know if that does the trick!

@lindseydiloreto
Copy link
Collaborator

This fix has been officially released in 4.3.5. 👍

@zizther
Copy link
Author

zizther commented Jun 6, 2023

Thanks for supporting this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants