Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/queue manager #45

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix/queue manager #45

merged 2 commits into from
Mar 27, 2023

Conversation

puckey
Copy link
Contributor

@puckey puckey commented Mar 21, 2023

Pulls in commit from #41

and adds:

  • avoid calling delegate?.onSkippedToSameCurrentItem() when the current index becomes one less due to a track before it being removed (the root cause of what fix: #42 - update current item correctly upon removal #43 fixes)
  • avoid calling onCurrentItemChanged unnecessarily in skip
  • move onSkippedToSameCurrentItem() call into skip & jump
  • fix a few tests

Christian Duvholt and others added 2 commits March 13, 2023 11:28
Fix removing items from queue other than the current track
a41b3ab
@puckey
Improve queue manager
f69a85e 
- avoid calling delegate?.onSkippedToSameCurrentItem() when the current index becomes one less due to a track before it being removed
- avoid calling onCurrentItemChanged unnecessarily in skip
- move onSkippedToSameCurrentItem() call into skip & jump
- fix a few tests
@puckey puckey mentioned this pull request Mar 21, 2023
Closed
@dcvz dcvz merged commit b10aea4 into doublesymmetry:main Mar 27, 2023
@fivecar fivecar mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puckey @dcvz