You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem description:
Such static property assignments prevent tree-shaking (which is still relevant in case of downshift in case it gets imported by some some unused part of the code, i.e. some ui-kit library which index.js reexports bunch of stuff):
Not mentioning that adding .default is not proper way of supporting a default import declaration. We've discussed this once here - kentcdodds/kcd-scripts#28
Suggested solution:
Remove .default and use exports: 'named' in rollup.config.js or create a separate file for cjs that could wrap the original entry to provide .default
make .resetIdCounter a separate export and not a static property of Downshift class
The text was updated successfully, but these errors were encountered:
remove .default and use exports: 'named' in rollup.config.js
create a separate file for cjs that could wrap the original entry to provide .default
would u like to have done, then I can work on this one - although not sure if I manage to do that before the weekend and I'm not sure how fast you'd like to release the new version
Problem description:
Such static property assignments prevent tree-shaking (which is still relevant in case of
downshift
in case it gets imported by some some unused part of the code, i.e. some ui-kit library which index.js reexports bunch of stuff):https://github.com/paypal/downshift/blob/d2df6ec05198609ec5abbbad92bdc91dcac3b8c9/src/index.js#L9-L10
Not mentioning that adding
.default
is not proper way of supporting a default import declaration. We've discussed this once here - kentcdodds/kcd-scripts#28Suggested solution:
.default
and useexports: 'named'
in rollup.config.js or create a separate file forcjs
that could wrap the original entry to provide.default
.resetIdCounter
a separate export and not a static property ofDownshift
classThe text was updated successfully, but these errors were encountered: