Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into accessibility issues #617

Closed
kentcdodds opened this issue Nov 7, 2018 · 2 comments
Closed

Look into accessibility issues #617

kentcdodds opened this issue Nov 7, 2018 · 2 comments

Comments

@kentcdodds
Copy link
Member

kentcdodds commented Nov 7, 2018

Ryan Florence mentioned that lots of combobox components (like downshift) get some things wrong:

  • "escape" when navigating the list vs. escape when typing
  • selecting the autocompleted portion
  • not autocompleting the wrong async results that come back in the a different order than they went out (we can't do anything about this because we don't deal with loading the items).

Let's look into whether we're getting these things wrong and see about fixing that.

@silviuaavram
Copy link
Collaborator

Escape right now clears our selectedInput but once ARIA will bump its version then the behavior should change.

We should support autocomplete too, adding the text in the input as the user moves through the options.

@silviuaavram
Copy link
Collaborator

Will close this since we already have #889 and #719 for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants