Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(useSelect): change the docsite stateReducer example #1044

Merged
merged 1 commit into from
May 9, 2020

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented May 9, 2020

What:
Showcase the Windows-specific behavior of a select on ArrowUp/ArrowDown with menu closed.
Instead of opening the menu with a highlightedIndex, we just select the previous/next item.

Why:
Better use case to illustrate.

How:
Change the stateReducer.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

Closes #792.

@silviuaavram silviuaavram merged commit 833f400 into master May 9, 2020
@silviuaavram silviuaavram deleted the docs/change-use-select-example branch May 9, 2020 18:06
@silviuaavram
Copy link
Collaborator Author

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSelect: add Windows Arrow Up/Down on button behavior
1 participant