Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 92d8f47 Revert "Fix cterm background color" breaks background color in console VIM #59

Closed
karlgluck opened this issue Mar 8, 2018 · 4 comments

Comments

@karlgluck
Copy link

See this revert of a previous commit

If I do a plain checkout of this theme:

cd ~/.vim/bundle && \
git clone https://github.com/dracula/vim.git dracula-theme

Then edit this file:

vim ~/.vim/bundle/dracula-theme/colors/dracula.vim

This is the result:

image

If I manually add the changes that this commit erased, then the background color works again:

image

@benknoble
Copy link
Member

benknoble commented Mar 9, 2018

Repro'd as well. Didn't notice in the current version using a dark-colored terminal. What's more, I think it makes the CursorLine setting even less noticeable (see #58 )

Edit: CursorLine is actually undetectable. What's worse, however, is that with the Dracula terminal theme this lack of background setting makes perfect sense. In a terminal with e.g. a white (blech) background, it's shoddy. But applying the cterm settings to the Normal hi group makes it much darker and I think harder to read.

All that is to say, I'm kind of in favor of leaving it the way it is, and recommend you either switch to a Dracula term scheme or use an autocmd to fix it for your machine.

@benknoble
Copy link
Member

Based on my testing, this is fixed by #62 . With the new changes, the bg is set appropriately regardless.

@dsifford Can you confirm this behavior, and let us know if it will solve the three issues mentioned here ?

@dsifford
Copy link
Member

Yeah, from the tests I've attempted, #62 should fix this.

@dsifford
Copy link
Member

Assuming this has been fixed by #62.. Reopen if that's not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants