Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloaded operators for MArrayPointer and MVariable, separted classes to different files #19

Closed
wants to merge 7 commits into from
Closed

Overloaded operators for MArrayPointer and MVariable, separted classes to different files #19

wants to merge 7 commits into from

Conversation

ttzytt
Copy link

@ttzytt ttzytt commented Feb 23, 2023 •
edited
Loading

Overview: What does this pull request change?

  1. Comparators and operators in MArrayPointer
  2. Comparators and operators in MVariables
  3. Separated classes to different files

Motivation and Explanation: Why and how do your changes improve the library?

As mentioned in the discussion, overloading these operators would be much easier to implement animation for algorithms.

Further Information and Comments

The __hash__ function may not be ideal, mentioned in the issue section.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section

@ttzytt
Copy link
Author

ttzytt commented Feb 23, 2023

By the way, some annotations in the code might not be in the doc's format. I might need to take a look at the format and make some changes.

@drageelr drageelr linked an issue Feb 23, 2023 that may be closed by this pull request
Overloading operators for MVariable, MArray and MArrayPointer classes. #18
Open
@drageelr drageelr added the enhancement New feature or request label Feb 28, 2023
@drageelr drageelr marked this pull request as draft February 28, 2023 09:56
@drageelr
Copy link
Owner

I have switched the PR to draft mode, kindly check the Allow edits from maintainers checkbox. If the option is still not visible in draft mode, close this PR and generate a new one with the option enabled.

P.S: Visit this link for more details.

@ttzytt
Copy link
Author

ttzytt commented Feb 28, 2023

I have switched the PR to draft mode, kindly check the Allow edits from maintainers checkbox. If the option is still not visible in draft mode, close this PR and generate a new one with the option enabled.

P.S: Visit this link for more details.

@drageelr

The checkbox is still not visible after you turned this into a draft. I guess there are probably some problems related to the fact that I forked this repo as a group. And when I created this PR, I was not the administrator of it, so I might not have access to open the edit access for maintainers. Now I have already gained administrator access, so I'll try to generate another PR.

If it still doesn't work, you can probably merge it first and then do some commit to fix it.

@ttzytt ttzytt closed this Feb 28, 2023
@ttzytt ttzytt reopened this Feb 28, 2023
@ttzytt ttzytt closed this Feb 28, 2023
@ttzytt ttzytt mentioned this pull request Feb 28, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overloading operators for MVariable, MArray and MArrayPointer classes.
3 participants
@ttzytt @drageelr @MqCreaple