Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Protoc plugin version #1117

Closed
wants to merge 4 commits into from
Closed

Unified Protoc plugin version #1117

wants to merge 4 commits into from

Conversation

244372610
Copy link
Contributor

Signed-off-by: sunwp [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sunwp <[email protected]>
@244372610 244372610 requested a review from a team as a code owner March 3, 2022 03:45
@codecov-commenter
Copy link

Codecov Report

Merging #1117 (3249b2c) into main (2bb44c1) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   45.81%   45.89%   +0.08%     
==========================================
  Files         130      130              
  Lines        9979     9983       +4     
==========================================
+ Hits         4572     4582      +10     
+ Misses       4887     4881       -6     
  Partials      520      520              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.89% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdn/supervisor/progress/progress.go 89.55% <0.00%> (-1.50%) ⬇️
client/daemon/peer/peertask_conductor.go 57.67% <0.00%> (+0.35%) ⬆️
scheduler/resource/peer.go 77.12% <0.00%> (+1.64%) ⬆️
pkg/source/httpprotocol/http_source_client.go 65.09% <0.00%> (+2.09%) ⬆️
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+3.70%) ⬆️

@gaius-qi gaius-qi closed this Mar 4, 2022
@gaius-qi gaius-qi deleted the feature/protocCompile branch March 9, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants