feat: scheduler download tiny file with range header #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim3ma
reviewed
Jan 21, 2022
scheduler/resource/peer.go
Outdated
| @@ -402,12 +402,17 @@ func (p *Peer) DownloadTinyFile(ctx context.Context) ([]byte, error) { | |||
| if err != nil { | |||
| return []byte{}, err | |||
| } | |||
| req.Header.Set("Range", fmt.Sprintf("bytes=%d-%d", 0, p.Task.ContentLength.Load())) | |||
Signed-off-by: Gaius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
- Coverage 45.96% 45.95% -0.01%
==========================================
Files 128 128
Lines 9134 9142 +8
==========================================
+ Hits 4198 4201 +3
- Misses 4463 4468 +5
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
force-pushed
the
feature/scheduler-download-tiny-file-with-range
branch
from
9ee832d to
30a7b57
Compare
hyy0322
approved these changes
Jan 21, 2022
lucy-cl
approved these changes
Jan 21, 2022
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaius [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: