Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scheduler download tiny file error #1052

Merged
merged 2 commits into from
Feb 8, 2022
Merged

fix: scheduler download tiny file error #1052

merged 2 commits into from
Feb 8, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Feb 8, 2022

Signed-off-by: Jim Ma [email protected]

Description

  1. Fix wrong range when download tiny file.
  2. Fix wrong peer id when download tiny file from dfget daemon.
  3. Update unit tests.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner February 8, 2022 08:14
hyy0322
hyy0322 approved these changes Feb 8, 2022
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit a855c0e into main Feb 8, 2022
@244372610 244372610 deleted the fix/scheduler-download-tiny-file branch February 8, 2022 08:37
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
fix: scheduler download tiny file error (#1052)
c14d36b 
* fix: scheduler download tiny file error

Signed-off-by: Jim Ma <[email protected]>

* chore: fix golang lint

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyy0322 hyy0322 hyy0322 approved these changes

@244372610 244372610 244372610 approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim3ma @244372610 @hyy0322