fix: delete peer's parent on PeerEventDownloadSucceeded event #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a peer leaves, it calls scheduler's LeaveTask() interface to notify scheduler that it's leaving. And LeaveTask() will re-schedule all its children to find a new parent by calling ScheduleParent(). But some of this peer's children might be in PeerStateSucceeded state, as they have finished downloading tasks from parent. So ScheduleParent() on such children is pointless. Let's delete peer's parent on PeerEventDownloadSucceeded event, so its parent won't call ScheduleParent() on it again, when its parent is leaving. Signed-off-by: Eryu Guan <[email protected]>
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
When a peer leaves, it calls scheduler's LeaveTask() interface to notify scheduler that it's leaving. And LeaveTask() will re-schedule all its children to find a new parent by calling ScheduleParent(). But some of this peer's children might be in PeerStateSucceeded state, as they have finished downloading tasks from parent. So ScheduleParent() on such children is pointless. Let's delete peer's parent on PeerEventDownloadSucceeded event, so its parent won't call ScheduleParent() on it again, when its parent is leaving. Signed-off-by: Eryu Guan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a peer leaves, it calls scheduler's LeaveTask() interface to
notify scheduler that it's leaving. And LeaveTask() will re-schedule
all its children to find a new parent by calling ScheduleParent().
But some of this peer's children might be in PeerStateSucceeded
state, as they have finished downloading tasks from parent. So
ScheduleParent() on such children is pointless.
Let's delete peer's parent on PeerEventDownloadSucceeded event, so
its parent won't call ScheduleParent() on it again, when its parent
is leaving.
Signed-off-by: Eryu Guan [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist