Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rbac to manager config interface #1179

Merged
merged 1 commit into from
Mar 23, 2022
Merged

feat: add rbac to manager config interface #1179

merged 1 commit into from
Mar 23, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add RBAC to manager config interface.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 23, 2022
@gaius-qi gaius-qi self-assigned this Mar 23, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 23, 2022 07:05
@codecov-commenter
Copy link

Codecov Report

Merging #1179 (0aa64b7) into main (f2031d5) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   46.31%   46.47%   +0.16%     
==========================================
  Files         132      133       +1     
  Lines       10250    10496     +246     
==========================================
+ Hits         4747     4878     +131     
- Misses       4960     5063     +103     
- Partials      543      555      +12     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.47% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/rpcserver/subscriber.go 49.56% <0.00%> (-9.81%) ⬇️
client/config/deprecated.go 0.00% <0.00%> (ø)
...ent/daemon/peer/peertask_piecetask_synchronizer.go 46.91% <0.00%> (ø)
client/daemon/peer/peertask_conductor.go 58.23% <0.00%> (+0.86%) ⬆️
client/daemon/daemon.go 6.54% <0.00%> (+1.41%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 53.33% <0.00%> (+2.98%) ⬆️
client/daemon/peer/peertask_bitmap.go 72.22% <0.00%> (+3.47%) ⬆️
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+3.70%) ⬆️
client/config/dfget.go 26.74% <0.00%> (+5.69%) ⬆️

@gaius-qi gaius-qi merged commit eb44965 into main Mar 23, 2022
@gaius-qi gaius-qi deleted the feature/manager branch March 23, 2022 07:41
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants