Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage GetCDN interface return scheduler info #1184

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

gaius-qi
Copy link
Member

Description

  • Manage GetCDN interface return scheduler info.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 23, 2022
@gaius-qi gaius-qi self-assigned this Mar 23, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 23, 2022 09:58
@gaius-qi gaius-qi requested review from imeoer, ansinlee and hyy0322 March 23, 2022 09:58
@codecov-commenter
Copy link

Codecov Report

Merging #1184 (7a0174b) into main (a3b0da4) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   46.05%   46.45%   +0.40%     
==========================================
  Files         133      133              
  Lines       10498    10498              
==========================================
+ Hits         4835     4877      +42     
+ Misses       5117     5066      -51     
- Partials      546      555       +9     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.45% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 58.23% <0.00%> (+1.23%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 53.33% <0.00%> (+22.96%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaius-qi gaius-qi merged commit 039791e into main Mar 24, 2022
@gaius-qi gaius-qi deleted the feature/manager-cdn branch March 24, 2022 07:46
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: generate manager protoc

Signed-off-by: Gaius <[email protected]>

* feat: manager cdn add scheduler info

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants