Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate grpc protos in namely/protoc-all image #1187

Merged
merged 5 commits into from
Mar 24, 2022
Merged

feat: generate grpc protos in namely/protoc-all image #1187

merged 5 commits into from
Mar 24, 2022

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 24, 2022
@gaius-qi gaius-qi self-assigned this Mar 24, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 24, 2022 12:16
@gaius-qi gaius-qi changed the title Feature/protoc feat: generate grpc protos in namely/docker-protoc Mar 24, 2022
@gaius-qi gaius-qi changed the title feat: generate grpc protos in namely/docker-protoc feat: generate grpc protos in namely/protoc-all image Mar 24, 2022
@gaius-qi gaius-qi merged commit 66194b0 into main Mar 24, 2022
@gaius-qi gaius-qi deleted the feature/protoc branch March 24, 2022 13:37
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: generate grpc protos in namely/protoc-all image (#1187)
998110f 
* feat: generate manager protoc

Signed-off-by: Gaius <[email protected]>

* chore: makefile add protoc command

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucy-cl lucy-cl lucy-cl approved these changes

@zzy987 zzy987 zzy987 approved these changes

@imeoer imeoer imeoer approved these changes

@jim3ma jim3ma Awaiting requested review from jim3ma jim3ma is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
None yet
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@gaius-qi @imeoer @zzy987 @lucy-cl