Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AnnounceTask and StatTask tests #1254

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Add AnnounceTask and StatTask tests #1254

merged 1 commit into from
Apr 15, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 15, 2022 •
edited by jim3ma
Loading

Signed-off-by: Gaius [email protected]

Description

  • Add AnnounceTask and StatTask tests.
  • Refactor dferror message.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone Apr 15, 2022
@gaius-qi gaius-qi self-assigned this Apr 15, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner April 15, 2022 04:22
@gaius-qi gaius-qi mentioned this pull request Apr 15, 2022
Closed
cndoit18
cndoit18 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eryugey
Copy link
Contributor

eryugey commented Apr 15, 2022

LGTM! Thanks for the tests!

jim3ma
jim3ma approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 14ff3dd into main Apr 15, 2022
@jim3ma jim3ma deleted the feature/announce-task-and-stat-task branch April 15, 2022 06:08
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
test: AnnounceTask and StatTask (#1254)
9c539fd 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucy-cl lucy-cl lucy-cl approved these changes

@cndoit18 cndoit18 cndoit18 approved these changes

@jim3ma jim3ma jim3ma approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
scheduler
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@gaius-qi @eryugey @jim3ma @cndoit18 @lucy-cl