Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note in protobuffer file has misspelling mistake #1411

Merged
merged 3 commits into from
Jun 27, 2022
Merged

note in protobuffer file has misspelling mistake #1411

merged 3 commits into from
Jun 27, 2022

Conversation

lilongfeng0902
Copy link

Description

information not infomation

Related Issue

none

Motivation and Context

Make a contribution to the commity from small things.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@lilongfeng0902 lilongfeng0902 requested a review from a team as a code owner June 26, 2022 09:33
@codecov-commenter
Copy link

Codecov Report

Merging #1411 (79a661e) into main (6c9ab75) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
- Coverage   45.02%   44.80%   -0.23%     
==========================================
  Files         110      110              
  Lines       10040    10040              
==========================================
- Hits         4521     4498      -23     
- Misses       5056     5082      +26     
+ Partials      463      460       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.80% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c2fdbf7 into dragonflyoss:main Jun 27, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* spelling error, just a little mistake

Signed-off-by: 李龙峰 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants