Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preheat skip certificate validation #786

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 9, 2021

Signed-off-by: Gaius [email protected]

Description

  • Manager preheat image skip certificate validation

Related Issue

Fixes #785

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 9, 2021
@gaius-qi gaius-qi self-assigned this Nov 9, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 9, 2021 06:43
Signed-off-by: Gaius <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #786 (509d232) into main (ec8ede0) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
+ Coverage   39.58%   39.62%   +0.03%     
==========================================
  Files          94       94              
  Lines        7647     7647              
==========================================
+ Hits         3027     3030       +3     
+ Misses       4226     4223       -3     
  Partials      394      394              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 39.62% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.09% <0.00%> (+0.62%) ⬆️

@gaius-qi gaius-qi merged commit 1d452b7 into main Nov 9, 2021
@gaius-qi gaius-qi deleted the feature/skip-certificate branch November 9, 2021 09:23
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: preheat skip certificate validation

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-heat request returns "null" and manager log shows "x509: certificate signed by unknown authority"
4 participants