Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize client storage gc log #790

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Nov 11, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner November 11, 2021 08:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #790 (56d46d5) into main (cb4be14) will increase coverage by 0.04%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
+ Coverage   40.34%   40.38%   +0.04%     
==========================================
  Files          94       94              
  Lines        7783     7787       +4     
==========================================
+ Hits         3140     3145       +5     
+ Misses       4237     4236       -1     
  Partials      406      406              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.38% <37.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/storage/storage_manager.go 20.77% <0.00%> (-0.12%) ⬇️
client/daemon/storage/local_storage.go 25.37% <100.00%> (+0.56%) ⬆️
client/daemon/peer/peertask_base.go 48.17% <0.00%> (+0.60%) ⬆️

@jim3ma jim3ma force-pushed the chore/optimize-client-storage-gc-log branch from 0d3cf2e to 56d46d5 Compare November 11, 2021 08:43
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 0dfadbb into main Nov 11, 2021
@jim3ma jim3ma deleted the chore/optimize-client-storage-gc-log branch November 11, 2021 12:15
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants