Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ItemViewBinder more open #245

Closed
drakeet opened this issue Dec 11, 2018 · 1 comment
Closed

Make ItemViewBinder more open #245

drakeet opened this issue Dec 11, 2018 · 1 comment
Assignees
@drakeet
Labels
todo

Comments

@drakeet
Copy link
Owner

drakeet commented Dec 11, 2018

The binders as a stateless role should allow more public access
@drakeet drakeet added the todo label Dec 11, 2018
@drakeet drakeet self-assigned this Dec 11, 2018
@drakeet
Copy link
Owner Author

drakeet commented Dec 17, 2018

Since this will cause API incompatibility, and there are many internal methods of Binder, if one of them wants to proxy, it is necessary to affect other state methods, so it's obviously not worth doing public. If someone has a proxy requirement, he should inherit the binder and submit an additional public method.

@drakeet drakeet closed this as completed Dec 17, 2018
@drakeet drakeet mentioned this issue Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drakeet drakeet

Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drakeet