Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching based on file sizes and file content where possible #12

Open
pjbull opened this issue Aug 17, 2020 · 1 comment
Open
Labels
caching enhancement New feature or request

Comments

@pjbull
Copy link
Member

pjbull commented Aug 17, 2020

Sometimes we can use etags, Azure provides the md5 hash, some providers have "versions," and there may be other options. Currently trusting file times is a little flaky.

Can we store the etag info on the local file somehow natively? It would be good if this metadata was around to be used across processes, etc.

We aren't doing this now, but we should check file sizes before we even check times. If sizes are different, the files are definitely different. Then we can fallback to if times are different, they are possibly different. Then, hashes can confirm files are different.

@pjbull pjbull changed the title Implement caching based on file content where possible Implement caching based on file sizes and file content where possible Sep 6, 2020
@pjbull pjbull added the enhancement New feature or request label Oct 2, 2020
@pjbull
Copy link
Member Author

pjbull commented Oct 2, 2020

May be related to #49 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caching enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant