Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated generation of splits for training can put rare species in wrong group #171

Open
pjbull opened this issue Dec 14, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@pjbull
Copy link
Member

pjbull commented Dec 14, 2021

This has one weird edge case that is likely rare, so just worth filing an issue for:

v0.mp4, antelope
v1.mp4, antelope  # v1 assigned test by antelope grouping
v1.mp4, cow       # subsequently v1 assigned train by cow grouping
v2.mp4, antelope
v4.mp4, cow
v5.mp4, cow

# test set is now missing antelope

Originally posted by @pjbull in #169 (comment)

@papapizzachess
Copy link

I tried to replicate the bug. It seems that the val set is missing antelope. v0 is training for antelope, v1 is training for cow, v2 is holdout for antelope, v4 is val for cow, and v5 is holdout for cow.

@papapizzachess
Copy link

I fixed the bug. However, when I try to push my changes, I get the error:
remote: Permission to drivendataorg/zamba.git denied to papapizzachess.
fatal: unable to access 'https://github.com/drivendataorg/zamba.git/': The requested URL returned error: 403
Do I need permission to push changes?

@pjbull
Copy link
Member Author

pjbull commented Nov 23, 2023

@papapizzachess when working on projects on GitHub, outside contributors need to fork the repository, contribute to their fork, and then create a pull request from their fork into the original project. That pull request will be reviewed and merged by the project maintainers.

@papapizzachess
Copy link

@papapizzachess when working on projects on GitHub, outside contributors need to fork the repository, contribute to their fork, and then create a pull request from their fork into the original project. That pull request will be reviewed and merged by the project maintainers.

Thanks! I got it to work.

@klwetstone klwetstone added the enhancement New feature or request label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants