Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide credentials thru environment variable? #104

Closed
anishkny opened this issue Oct 15, 2018 · 3 comments · Fixed by #107
Closed

Provide credentials thru environment variable? #104

anishkny opened this issue Oct 15, 2018 · 3 comments · Fixed by #107
Labels
enhancement help wanted

Comments

@anishkny
Copy link
Contributor

It is often useful in CI systems etc to provide credentials via an environment variable. Is this possible in dbxcli?

PS: Holy crap @diwakergupta its been a long time and no see! ✋
@vaithak vaithak mentioned this issue Oct 19, 2018
Merged
@diwakergupta
Copy link
Collaborator

@anishkny hola!! 👋

Will cmdline flags work or you absolutely need env variables? I'll look into it.

@vaithak vaithak mentioned this issue Oct 20, 2018
Merged
@vaithak
Copy link
Contributor

vaithak commented Oct 20, 2018

@diwakergupta I have added the feature to provide keys using environment variables in PR #107 . Please review it. Thanks.

@anishkny
Copy link
Contributor Author

Will cmdline flags work or you absolutely need env variables? I'll look into it.

cmdline flags should be fine although env vars is a commonly used idiom elsewhere. #107 seems promising!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature for adding keys by environment variables vaithak/dbxcli
3 participants
@diwakergupta @anishkny @vaithak