Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some basic latching to concurrency testing in IncrementalIndexTest #1710

Merged
merged 1 commit into from
Sep 15, 2015
Merged

Add some basic latching to concurrency testing in IncrementalIndexTest #1710

merged 1 commit into from
Sep 15, 2015

Conversation

drcrallen
Copy link
Contributor

No description provided.

drcrallen
drcrallen reviewed Sep 8, 2015
View reviewed changes
processing/src/test/java/io/druid/segment/data/IncrementalIndexTest.java
Thread.currentThread().interrupt();
throw Throwables.propagate(e);
}
currentlyRunning.incrementAndGet();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason diff thinks this was deleted rather than just moved

@drcrallen drcrallen closed this Sep 8, 2015
@drcrallen drcrallen reopened this Sep 8, 2015
@nishantmonu51
Copy link
Member

+1

@drcrallen drcrallen force-pushed the incrementalIndexConcurrentTestLatching branch from a787ed2 to d684980 Compare September 10, 2015 17:07
fjy added a commit that referenced this pull request Sep 15, 2015
@fjy
Merge pull request #1710 from metamx/incrementalIndexConcurrentTestLa…
8b071a7 
…tching

Add some basic latching to concurrency testing in IncrementalIndexTest
@fjy fjy merged commit 8b071a7 into apache:master Sep 15, 2015
@drcrallen drcrallen deleted the incrementalIndexConcurrentTestLatching branch September 15, 2015 20:58
@guobingkun
Copy link
Contributor

@drcrallen , Not sure if it's related to this PR.
But I keep getting this error even when I run unit tests locally.

Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.104 sec <<< FAILURE! - in io.druid.segment.data.IncrementalIndexTest
testConcurrentAddRead[0](io.druid.segment.data.IncrementalIndexTest)  Time elapsed: 0.252 sec  <<< FAILURE!
java.lang.AssertionError: Did not hit concurrency, please try again
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.druid.segment.data.IncrementalIndexTest.testConcurrentAddRead(IncrementalIndexTest.java:386)

@drcrallen
Copy link
Contributor Author

@guobingkun Possibly, putting in a PR to help fix the problem.

@guobingkun
Copy link
Contributor

@drcrallen Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drcrallen @nishantmonu51 @guobingkun @fjy