@validate-file-exists doesn't seem to take --root into account

[gaelg]

I tried drush @docker sql-query --file=../private/$DUMP and got [error] File(s) not found: ../private/2017-11-02_17:12.sql
The same command work if I execute it directly inside the container, without any alias.
After some search, I found out that if I remove "@validate-file-exists file" from SQLCommands.php function query(), it works. I tried a getcwd() in validateFileExists(), before the call to file_exists() and got the wrong dir. I think it's because validateFileExists() doesn't take --root into account, which is added when the command is executed through SSH.

[weitzman]

The cwd should already be Drupal root by the time @validate-file-exists starts doing its work. See

drush/src/Boot/DrupalBoot.php

Line 183 in 514419f

chdir($drupal_root);

.

[greg-1-anderson]

Relative file paths used in options (e.g. --file) should be evaluated relative to the cwd that was set prior to running Drush, not relative to the Drupal root, which is set as described above.

The original cwd is available via the key env.cwd in config. @validate-file-exists should probably convert relative paths to absolute from env.cwd before testing (and set the $option to ensure consistency).

Relative paths for remote commands are perhaps a dubious proposition. Logically, these are relative to the $HOME directory of the remote user.

[greg-1-anderson]

Drush 8 and earlier sets the cwd for remote commands to the Drupal root, so I suppose we should maintain that behavior.

[weitzman]

Its a problem in SqlCommands. Fixing now ...

[greg-1-anderson]

Maybe it would be helpful to cwd in preflight?

[weitzman]

Fixed in #3135. We decided not to move the chdir() to Preflight.

[gaelg]

Thank you, it works! :)