Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&static str #407

Open
wangjiawen2013 opened this issue Jan 8, 2025 · 0 comments
Open

&static str #407

wangjiawen2013 opened this issue Jan 8, 2025 · 0 comments

Comments

@wangjiawen2013
Copy link

wangjiawen2013 commented Jan 8, 2025

Hi,
The following code is a common way to return value:

fn parse_version(header: &[u8]) -> Result<Version, &'static str> {
    match header.get(0) {
        None => Err("invalid header length"),
        Some(&1) => Ok(Version::Version1),
        Some(&2) => Ok(Version::Version2),
        Some(_) => Err("invalid version"),
    }
}

By this way, the error will be returned as a &'static str and we can return any errors with this way, what's the advantage of thiserror over &'static str?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant