Merge autofill code into a component #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntextMenus API is missing.
sammacbeth
force-pushed
the
sam/autofill-component
branch
from
447b3f1
to
a3905f2
Compare
GioSensation
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prime motivation here was to add guards around use of the
contextMenusAPI, so the extension doesn't instantly crash on platforms that don't support this API (Firefox for Android and Safari). However, I also took the liberty of refactoring the autofill code to move as much of it as possible together into a single file, as it is current spread over quite a few places, making it difficult to track what's going on.Unfortunately, the diff is not very helpful, but all this is, is the code from
email-utilsput into a class, and all the message-handler functions, previously inmessage-handlers.jsare moved to be member functions of that class. Then I also merged the initialization code fromevents.jsandstartup.jsinto the constructor and init functions of this class.