Do not run tests with OTP 22.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgerrand Could you please take a look at this PR? |
sgerrand
suggested changes
Mar 8, 2021
dolfinus
changed the title
See elixir-ecto/ecto#3335 (comment) for more details
dolfinus
changed the title
|
@dolfinus: Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some of PRs are failing:
#107
#97
This is caused bu a bug in the 22.0.1 OTP version:
elixir-ecto/ecto#3335 (comment) for more details
Here I've changed the matrix build to avoid this.
Also recently ubuntu-latest tag was changed, now it is pointing to ubuntu-20.04 instead of ubuntu-18.04. This causes an error during Elixir installation step:
https://github.com/dolfinus/paginator/runs/2045756587?check_suite_focus=true
So I've changed ubuntu version back to 18.04.
Another thing that was changed here - workflow has been updated to be run on pull_requests too.
Without this change every PR from an external repo will look like this:
without actually running any of these checks.
Here is an example of workflow run:
https://github.com/dolfinus/paginator/actions/runs/633779496
And this is en example of run which will be performed after #97 rebase:
https://github.com/dolfinus/paginator/actions/runs/633782580