Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add French Translation #1

Closed
duncan222 opened this issue Apr 24, 2024 · 1 comment
Closed

FEATURE: Add French Translation #1

duncan222 opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@duncan222
Copy link
Owner

duncan222 commented Apr 24, 2024

Task Description and Plan: There is a current issue in the repository that consist of adding option to choose French for the language of the website. In order to do this, I would have to do a direct translation of the words in the i18n .json files, and correlate this change amongst all projects: admin, mobile. Once finished, I will need to test if the page correctly translates its text to French.

Image showing the problem and its room for enhancement:

Image

Risk Assessment: there is a time risk involved with adding this feature, considering it requires manually translating each line. Hopefully I can find a tool that does it automatically for me instead of translating 1000+ lines of text. There is also the risk of bad translation as well.

Image showing that all the items in the French translation JSON are all in English still:

Image

**UPDATE: translation only needed in the admin page, looks as if it has been applied to customer end **

Feature/Bug has been fixed

here is a link to the pull-request:

ever-co/ever-demand#1570 (comment)

The enhancement was done through researching techniques for translating large JSON files, and while doing so, I came across an article on the azure translator. With this new knowledge I decided to make an Azure account and develop a script from which I could generate the translated text. Once this was translated, I swapped out the previous JSON file in the project and updated the dropdown list to include French as an option.

This was tested by running the application and seeing if the option for French was in the dropdown, and if it effectively alters the text on the screen.

Image

Image

@duncan222 duncan222 self-assigned this Apr 24, 2024
@duncan222 duncan222 converted this from a draft issue Apr 24, 2024
@duncan222
Copy link
Owner Author

duncan222 commented Apr 24, 2024

The pull request and actually code for the issue is located here: ever-co/ever-demand#1570 (comment)

I am unable to connect this repo with this project due to security measures placed by its owners.

@duncan222 duncan222 added the enhancement New feature or request label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant