Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin & Log Funcs don't implement backoff & retry when 429 response received #49

Open
dylanraithel opened this issue Sep 1, 2023 · 1 comment

Comments

@dylanraithel
Copy link

Hey Duo!

We've noticed our service receiving 429 responses when hitting your APIs using the golang SDK. It looks like in the docs that the SDK should implement a backoff/retry but it looks like it doesn't. We'll handle this ourselves for now but thought you should know. Please advise.

https://help.duo.com/s/article/1338?language=en_US

func (c *Client) GetAdminLogs(mintime time.Time, options ...func(*url.Values)) (*AdminLogResult, error) {

func (c *Client) GetAuthLogs(mintime time.Time, window time.Duration, options ...func(*url.Values)) (*AuthLogResult, error) {

@dylanraithel dylanraithel changed the title Admin & Log Funcs don't implement backoff when 429 response received Admin & Log Funcs don't implement backoff & retry when 429 response received Sep 1, 2023
@AaronAtDuo
Copy link
Contributor

We have the backoff behavior implemented in a few of the other SDKs but have not gotten to this one yet, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants