From 9bee7d54f4447eb0b6ead535ccc7ad3a2205f734 Mon Sep 17 00:00:00 2001 From: Gerrit User 1184479 <1184479@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Thu, 16 Mar 2017 17:21:09 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: Sorry, but this is not the way to do that. Registry key approach was discussed downstream in nodejs, Heath Stewart who is responsible for the VS installer said explicitly that the registry entry is not supported (https://github.com/nodejs/node-gyp/pull/1103#issuecomment-280146014) In node-gyp we used Rafael's powershell script that can query VS COM server (https://github.com/nodejs/node-gyp/pull/1130). We used that to find VS and set environment variables. IMHO we should do the same thing here. Patch-set: 4