-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn this crate into a workspace #58
Comments
While working on this, I came across another issue that is worth noting. With the previous setup we were able to add the opening proof creation in zero-knowledge as a method on the opening.verify(leaf);
opening.gadget(&mut composer, leaf); With the creation of a workspace and the division into the generic merkle tree and the poseidon merkle tree, we have no access to opening_gadget(&mut composer, &opening, leaf); This is not a huge drawback of course but I felt it is worth mentioning in the re-designing process. |
Summary
Separate the generic implementation of a merkle tree from the hash- and type-specific implementations of the
Aggregate
trait.With this change we will have one crate for the generic merkle tree that exposes
Aggregate
,Tree
,Opening
andWalk
and each their own crate for the specific implementations of theAggregate
trait.So far this will result in having crates for:
dusk-merkle
crate and not as its own)The generic crate
dusk-merkle
will be at the root of the workspace andposeidon-merkle
(name can be changed) will become a member.Relevant Context
See #56 for more context
The text was updated successfully, but these errors were encountered: