On linux with python lib, rename events seems not associate path correctly when moving accross folders

[yufei-pan]

mv tf/t1 ./t0

{"effect_time":1738138917604701582,"path_name":".../test/tf/t1","associated_path_name":".../test/tf/t0","effect_type":"rename","path_type":"file"}

while the associated path should be .../test/t0

This also happens when trying to move files inside

[e-dant]

This is strictly an issue with inotify.

The bug is that we weren't checking what (path, watch-descriptor) pair the event is associated with.

Per the kernel: https://github.com/torvalds/linux/blob/cabb4685d57ed50cd197498d2ac946ad5b6272e7/include/uapi/linux/inotify.h#L15-L27

[e-dant]

Should be fixed in: 4d8f978

More documentation on the fix here: 691729b

Some testing here:

$ tool/hone && tool/build --no-run && rm -rf /tmp/wtr && mkdir /tmp/wtr && ( out/this/Release/wtr.watcher /tmp/wtr -ms 1000 | jq '. | select(.associated)' ) & ( cd /tmp/wtr ; sleep 0.1 ; mkdir a ; touch a/b ; mv a/b b ; )
{
  "path_type": "file",
  "path_name": "/tmp/wtr/a/b",
  "effect_type": "rename",
  "effect_time": 1738450318057588500,
  "associated": {
    "path_type": "file",
    "path_name": "/tmp/wtr/b",
    "effect_type": "rename",
    "effect_time": 1738450318057587200,
    "associated": null
  }
}